Skip to content

Commit

Permalink
No reason for putting the manifest in the ${basedir}
Browse files Browse the repository at this point in the history
The one single reason for doing it is to allow to import in the workspace the
`sbt.full.library` project, so that it can be correctly consumed by the
dependent projects (e.g., the `core project). However, given we practically
never had to do so in the past 6 months, it feels reasonable to remove the
flexiblity in the name of a cleaner build. In case you will need to import he
`sbt.full.library` project in Eclipse at any point, just create the required
.classpath and .project, and copy/paste in the project's root the META-INF
folder generated by the build (look in the target/ folder). Make  sure to do
the same for the `sbt.compiler.interface` project.
  • Loading branch information
dotta committed Sep 10, 2013
1 parent 65306fd commit e8a3410
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 70 deletions.
19 changes: 0 additions & 19 deletions org.scala-ide.sbt.full.library.source/pom.xml
Expand Up @@ -148,25 +148,6 @@

<build>
<plugins>
<plugin>
<!-- automatically clean up the generated META-INF folder -->
<artifactId>maven-clean-plugin</artifactId>
<configuration>
<excludeDefaultDirectories>true</excludeDefaultDirectories>
<filesets>
<fileset>
<directory>./</directory>
<includes>
<include>META-INF/**/*</include>
<include>META-INF</include>
<include>target/**/*</include>
<include>target</include>
</includes>
<followSymlinks>false</followSymlinks>
</fileset>
</filesets>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
Expand Down
7 changes: 0 additions & 7 deletions org.scala-ide.sbt.full.library/.classpath

This file was deleted.

2 changes: 0 additions & 2 deletions org.scala-ide.sbt.full.library/.gitignore
@@ -1,3 +1 @@
target/
lib/
META-INF
21 changes: 0 additions & 21 deletions org.scala-ide.sbt.full.library/.project

This file was deleted.

21 changes: 0 additions & 21 deletions org.scala-ide.sbt.full.library/pom.xml
Expand Up @@ -131,34 +131,13 @@
</profiles>

<build>
<outputDirectory>${basedir}</outputDirectory>
<plugins>
<plugin>
<!-- automatically clean up the generated META-INF folder -->
<artifactId>maven-clean-plugin</artifactId>
<configuration>
<excludeDefaultDirectories>true</excludeDefaultDirectories>
<filesets>
<fileset>
<directory>./</directory>
<includes>
<include>META-INF/**/*</include>
<include>META-INF</include>
<include>target/**/*</include>
<include>target</include>
</includes>
<followSymlinks>false</followSymlinks>
</fileset>
</filesets>
</configuration>
</plugin>
<plugin>
<!-- generate the MANIFEST.MF file, and create the bundle -->
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<configuration>
<outputDirectory>${project.build.directory}/lib</outputDirectory>
<manifestLocation>${basedir}/META-INF</manifestLocation>
<instructions>
<Bundle-Vendor>scala-ide.org</Bundle-Vendor>
<Bundle-SymbolicName>org.scala-ide.sbt.full.library</Bundle-SymbolicName>
Expand Down

0 comments on commit e8a3410

Please sign in to comment.