Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid adding too many quotes #41

Closed
IvanMathy opened this issue Jun 16, 2020 · 2 comments
Closed

Avoid adding too many quotes #41

IvanMathy opened this issue Jun 16, 2020 · 2 comments
Assignees
@IvanMathy
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
Release 1.1.0

Comments

@IvanMathy
Copy link
Owner

When typing a quote next to an already existing quote, the editor gets a bit overzealous and adds two. Instead, we should check if the next character is a quote, and only add one if that's the case.
@IvanMathy IvanMathy added bug Something isn't working good first issue Good for newcomers labels Jun 16, 2020
@IvanMathy
Copy link
Owner Author

IvanMathy commented Jun 16, 2020 •
edited

Note: this probably needs to get fixed in Savannakit

@IvanMathy IvanMathy self-assigned this Jun 17, 2020
@IvanMathy IvanMathy added this to the Release 1.1.0 milestone Jun 17, 2020
@IvanMathy
Copy link
Owner Author

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanMathy IvanMathy

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Release 1.1.0
Development

No branches or pull requests
1 participant
@IvanMathy