Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search skipping highlights #3

Closed
rashidasgari opened this issue May 10, 2014 · 5 comments
Closed

Search skipping highlights #3

rashidasgari opened this issue May 10, 2014 · 5 comments
Assignees

Comments

@rashidasgari
Copy link

The primary highlight works fine but the secondary highlight skips every 5 words.

@IvanoBilenchi
Copy link
Owner

@rashidasgari I cannot reproduce this issue. The test app is unaffected, and so are my other apps using it. Could you provide a code sample or steps to reproduce this?

@rashidasgari
Copy link
Author

Thanks ivan. You are right, the sample app is working fine. Do you thinks
it is because i'm using arabic alphabet?

On Sun, May 11, 2014 at 12:40 AM, Ivano Bilenchi
notifications@github.comwrote:

@rashidasgari https://github.com/rashidasgari I cannot reproduce this
issue. The test app is unaffected, and so are my other apps using it. Could
you provide a code sample or steps to reproduce this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-42752929
.

@IvanoBilenchi
Copy link
Owner

@rashidasgari That may be it, I never tested it with Arabic. I'll have a look into it tomorrow.

Mind providing a sample text-word pair to help me reproduce it? That may speed things up a bit, especially if this only happens with some search strings (I'm no arabic speaker :p)

@rashidasgari
Copy link
Author

Yeah sure thing. Just copy and paste a piece of text from this link
http://fa.wikipedia.org/wiki/%D8%A7%D9%BE%D9%84_(%D8%B4%D8%B1%DA%A9%D8%AA)
This should do it. I somehow managed to find another way. I dismiss the
keyboard when you hit the search button and display a toolbar to go to the
next word. And in the "(void)scrollRectToVisible:(CGRect)rect
animated:(BOOL)animated
consideringInsets:(BOOL)considerInsets" method i add some value like 50 or
70 to the contentoffset.y. But i think it would be awesome if you could fix
this issue since your work must of helped alot of developers. If you could
find a way to scroll the textview in a way that each dark highlight word is
displayed in the middle of the view.

On Sun, May 11, 2014 at 2:43 PM, Ivano Bilenchi notifications@github.comwrote:

That may be it, I never tested it with Arabic. I'll have a look into it
tomorrow.

Mind providing a sample text-word pair to help me reproduce it? That may
speed things up a bit, especially if this only happens with some search
strings (I'm no arabic speaker :p)


Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-42766875
.

@IvanoBilenchi
Copy link
Owner

@rashidasgari I still didn't manage to reproduce the issue you pointed out. Anyway, I implemented the feature you requested (and other stuff as well). Check out the latest commits.

You can now scroll the primary match in the middle of the text view by calling scrollToMatch: or scrollToString: with atScrollPosition:ICTextViewScrollPositionMiddle.

Let me know if that workarounds the issue you were experiencing. I'll be waiting for feedback before actually confirming this as the stable 1.1.0 version.

@IvanoBilenchi IvanoBilenchi self-assigned this May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants