Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Travis file with default Haskell image #44

Closed
chriz-zeller opened this issue Dec 9, 2017 · 2 comments
Closed

Simplify Travis file with default Haskell image #44

chriz-zeller opened this issue Dec 9, 2017 · 2 comments

Comments

@chriz-zeller
Copy link
Contributor

As a reference see:

https://docs.travis-ci.com/user/languages/haskell/
and
https://github.com/ivanperez-keera/dunai/blob/develop/.travis.yml

That is, use the standard building image for Haskell ("ghc" variable, remove install section, etc.).

chriz-zeller pushed a commit that referenced this issue Dec 9, 2017
@chriz-zeller chriz-zeller self-assigned this Dec 9, 2017
@ivanperez-keera
Copy link
Owner

ivanperez-keera commented Dec 10, 2017

Ok. So, just to clarify this issue, what you are saying is that it needs to do what it does, but more simply (using the simpler, standard image).

So, would what remains at this point is to make sure the examples are compiled, is that right?

@chriz-zeller
Copy link
Contributor Author

The simplified script does not contain the flag for examples. I guess install and script should be modified in the simplified script to make sure that the examples are compiled.

Explanation:

With the recent simplification we are using the default install and script.
That is for install:

cabal install --only-dependencies --enable-tests

That is for script:

cabal configure --enable-tests && cabal build && cabal test

See also
https://docs.travis-ci.com/user/languages/haskell/

Both steps can be modified by adding install and/or script in .travis.yml while the rest of the simplification can remain as it is.

@ivanperez-keera ivanperez-keera changed the title Travis file needs improvement Travis file could be simplified Dec 12, 2017
@ivanperez-keera ivanperez-keera changed the title Travis file could be simplified Simplify Travis file with default Haskell image Dec 12, 2017
chriz-zeller pushed a commit that referenced this issue Dec 12, 2017
- Sets flag for examples.
- Adds libraries that are needed for the examples.

Refs #44 and #45.
chriz-zeller pushed a commit that referenced this issue Dec 12, 2017
chriz-zeller pushed a commit that referenced this issue Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants