Indicator is showing up many more times than one

[blockiyt]

Details

• iOS Version 16.0 beta 3
• Framework Version 1.6.4
• Installed via Manually

Describe the Bug
As soon as the Indicator got fired one time, anything you do on the UI triggers many more times.

RPReplay_Final1657907183.mov

[LouisTay]

A workaround:

showIndicator = true
try? await Task.sleep(nanoseconds: 10)
showIndicator = false

[gongzhang]

Hi @ivanvorobei , long time no see 😄

I just re-implement the SwiftUI support for SPIndicator. And you can find it here. I believe the commit will fix this issue.

What's more, the new implementation also supports multi-window iPad app. The indicator always come up at correct window when using SwiftUI modifier. However, I have to deprecate the old APIs.

[ivanvorobei]

Is it for swiftui version or uikit? sorry for delay

[gongzhang]

@ivanvorobei Totally fine :) It's a fix for the current SwiftUI implementation.

[ivanvorobei]

@gongzhang can you make PR ?

[gongzhang]

@ivanvorobei Thanks! But I don't have the dev environment right now. You can also cherrypick gongzhang@38108b1

[bootuz]

Have similar issue

[bootuz]

A workaround:

showIndicator = true
try? await Task.sleep(nanoseconds: 10)
showIndicator = false

@LouisTay where should I place this? can you show an example?

[AsadFarooq5777]

facing similar issue

[Behtold]

My crutch:

extension View {
    public func mySPIndicator(
        isPresent: Binding<Bool>,
        title: String,
        duration: TimeInterval = 2.0,
        presentSide: SPIndicatorPresentSide = .top,
        dismissByDrag: Bool = true,
        preset: SPIndicatorIconPreset = .done,
        haptic: SPIndicatorHaptic = .none,
        completion: (()-> Void)? = nil
    ) -> some View {
        let now = Date().timeIntervalSince1970
       
        let present = (startShow > now - duration && title == currentTitle)
            ? Binding(get: { return false }, set: {_,_ in }) : isPresent
        if isPresent.wrappedValue {
            startShow = now
            currentTitle = title
        }
        let indicatorView = SPIndicatorView(title: title, preset: preset)
        indicatorView.presentSide = presentSide
        indicatorView.dismissByDrag = dismissByDrag
        indicatorView.completion = completion
        return SPIndicator(isPresent: present, indicatorView: indicatorView, duration: duration, haptic: haptic)
    }
}

fileprivate var startShow: TimeInterval = Date().timeIntervalSince1970
fileprivate var currentTitle: String?