Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't play nice with black navigation bar(s) #27

Closed
magnett opened this issue Feb 5, 2019 · 10 comments
Closed

Doesn't play nice with black navigation bar(s) #27

magnett opened this issue Feb 5, 2019 · 10 comments

Comments

@magnett
Copy link

magnett commented Feb 5, 2019

Hi!
First of all thanks for this great library!
I am using cocoapods 1.4.2 and found out that the transition doesn't work right if the source controller is embedded in an navigation controller with barStyle = .black
Most of the times the transition doesn't happen and when it does, it does with significant delay. If the barStyle is default there is no problem.

@ivanvorobei
Copy link
Owner

Please, record gif or create example project

@magnett
Copy link
Author

magnett commented Feb 5, 2019

I created an example project. Please note that in simulator it runs fine however it doesn't in a physical device (tested on iPhone 6) unless you change the barStyle of the navigation bar to .default

@ivanvorobei
Copy link
Owner

Thanks, I am tested now

@ivanvorobei
Copy link
Owner

@magnett I am tested on my iPhone X, and iPhone 6+. All ok... Or maybe I am not understand you. I am record screen, please, see it:

screenrecording_02-05-2019 18-27-56

@magnett
Copy link
Author

magnett commented Feb 5, 2019

I though it would be better to record a video instead of a gif in order to watch the console output and hear an audible sound when i tap and when the transition occurs. Also, let me add that exactly the same issue happens to my iPad (2017).
YouTube video

@ivanvorobei
Copy link
Owner

@magnett sorry, I don’t see any problem on video

@magnett
Copy link
Author

magnett commented Feb 5, 2019

Really? Don't you see that there are delays up to 3-4 seconds from the moment the button is tapped since the transition begins?

@ivanvorobei
Copy link
Owner

Yes, now I now see the problem. Very strange behaves - if you press twice, the controller will instantly show up. I'm afraid this is not a library issue.

@ivanvorobei
Copy link
Owner

For example if you try

self.present(productContainerVC, animated: true, completion: complection)

You can see delay also. The library is not related to your problem, you need to look for another problem.

@magnett
Copy link
Author

magnett commented Feb 6, 2019

You were right. Any kind of modal transition under black navigation bar was having that delay. Just to let you (and anyone might having that issue) know, the solution was:
DispatchQueue.main.asyncAfter(deadline: .now()) { self.presentAsStork(someViewController) }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants