-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't play nice with black navigation bar(s) #27
Comments
Please, record gif or create example project |
I created an example project. Please note that in simulator it runs fine however it doesn't in a physical device (tested on iPhone 6) unless you change the barStyle of the navigation bar to .default |
Thanks, I am tested now |
@magnett I am tested on my iPhone X, and iPhone 6+. All ok... Or maybe I am not understand you. I am record screen, please, see it: |
I though it would be better to record a video instead of a gif in order to watch the console output and hear an audible sound when i tap and when the transition occurs. Also, let me add that exactly the same issue happens to my iPad (2017). |
@magnett sorry, I don’t see any problem on video |
Really? Don't you see that there are delays up to 3-4 seconds from the moment the button is tapped since the transition begins? |
Yes, now I now see the problem. Very strange behaves - if you press twice, the controller will instantly show up. I'm afraid this is not a library issue. |
For example if you try
You can see delay also. The library is not related to your problem, you need to look for another problem. |
You were right. Any kind of modal transition under black navigation bar was having that delay. Just to let you (and anyone might having that issue) know, the solution was: |
Hi!
First of all thanks for this great library!
I am using
cocoapods 1.4.2
and found out that the transition doesn't work right if the source controller is embedded in an navigation controller withbarStyle = .black
Most of the times the transition doesn't happen and when it does, it does with significant delay. If the barStyle is default there is no problem.
The text was updated successfully, but these errors were encountered: