Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not dismissing after scroll #7

Closed
hiroshihorie opened this issue Dec 9, 2018 · 7 comments
Closed

Not dismissing after scroll #7

hiroshihorie opened this issue Dec 9, 2018 · 7 comments

Comments

@hiroshihorie
Copy link

func scrollViewDidScroll(_ scrollView: UIScrollView) {
    SPStorkController.scrollViewDidScroll(scrollView)
}

Adding this code does make it pan with scroll but letting go after pulling down still does not make it dismiss.

@ivanvorobei
Copy link
Owner

Yes, it correct way. It should not close. SPStorkController.scrollViewDidScroll only for interactive

@hiroshihorie
Copy link
Author

Thanks for your response.
What's the best way to make it dismiss ?

Also, when interactive with scrollview it's more harder to drag, requires more force. how can i adjust this?

@ivanvorobei
Copy link
Owner

Now, unfortunately, this is not configurable. I will take into account your wishes and add it.

@hiroshihorie
Copy link
Author

Oh, I see. I just didn't understand the point of interative-ness if it's not going to dismiss at the end.
I will try to implement this. shouldn't be difficult.
Thank you for your code.

@ivanvorobei
Copy link
Owner

Thanks! You can try create pull request

@ivanvorobei
Copy link
Owner

@Luccifer
Copy link

still not dismissing, only custom animations like letter "г" or from the screen edges...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants