Allow svg symbol to be placed into another location #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fotinakis
reviewed
Apr 28, 2017
| @@ -5,6 +5,9 @@ | |||
| ajax.onload = function(e) { | |||
| var div = document.createElement('div'); | |||
| div.innerHTML = ajax.responseText; | |||
| if ({{LOADER_LOCATION_ENABLED}}) { | |||
| return document.getElementById('{{LOADER_LOCATION}}').appendChild(div) | |||
| } | |||
| document.body.insertBefore(div, document.body.childNodes[0]); | |||
There was a problem hiding this comment.
@kiwiupover It looks like you're duplicating the insertion of the div, rather than changing it's location. I think you just want to make document.body.childNodes[0] on this line dynamic, right? Maybe adding a single config property like loaderLocation and having it default to 'body'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First thanks for a great project
We are using a visual regressions in our tests and the embedded svgJar object is not included in output of test unless the svgJar symbol object is placed into the
#ember-testing-container. We are using percy.ioIs this something worth adding to this project?