Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order of upsampling_dilations #22

Open
junjun3518 opened this issue Jul 6, 2021 · 1 comment
Open

The order of upsampling_dilations #22

junjun3518 opened this issue Jul 6, 2021 · 1 comment

Comments

@junjun3518
Copy link

Hi! My name is Junhyeok Lee and I appreciate your works!
Maybe I found a slight mistake in your config file.

"upsampling_dilations": [
[1, 2, 1, 2],
[1, 2, 1, 2],
[1, 2, 4, 8],
[1, 2, 4, 8],
[1, 2, 4, 8]
],

In Wavegrad Appendix A, they mentioned "The dilation factors of four convolutional layers are 1, 2, 4, 8 for the first three UBlocks and 1, 2, 1, 2 for the rest". Since they listed kernel sizes starting from the block closest to x(5,5,3,2,2), it seems that upsampling_dilations should be [[1,2,4,8]*3, [1,2,1,2]*2].
Could you confirm this?

@ivanvovk
Copy link
Owner

ivanvovk commented Jul 7, 2021

@junjun3518 Thank you very much. Checked it quickly, and seems like you are right, I am very sorry for that bug. I am planning to make a huge update of this repo to get better quality of generation, and this will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants