Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring - Exception Handlling #43

Closed
ivanwilliammd opened this issue Apr 6, 2024 · 2 comments · Fixed by #45 or #46
Closed

Refactoring - Exception Handlling #43

ivanwilliammd opened this issue Apr 6, 2024 · 2 comments · Fixed by #45 or #46
Assignees
Labels
enhancement New feature or request

Comments

@ivanwilliammd
Copy link
Owner

Based on suggestion di thread ini
#31 (comment)

ada usulan untuk buat new Folder untuk handling exception baru dan melakukan refactoring.

Note:

  1. Code perlu dipastikan backward compatible dari 7.4, 8.0, 8.1, 8.2, 8.3
  2. Jangan melakukan strictly typing berlebihan khususnya untuk ternary based variable
@yudistirasd
Copy link
Collaborator

Plannya nanti seperti ini :
src/Exception/FHIRException.php ... dst
src/Exception/KFA / Terminology Exception.php ... dst

Ada masukan pak?

@ivanwilliammd
Copy link
Owner Author

Plannya nanti seperti ini : src/Exception/FHIRException.php ... dst src/Exception/KFA / Terminology Exception.php ... dst

Ada masukan pak?

Saya usul seperti ini @yudistirasd ... kira2 dari yg lain ada masukan @YogiPristiawan @SyaefulKai ?
Dan juga untuk naming convention sprtinya perlu kita rapikan jadi kesepakatan camel case, karena di laravel kalau pakai capslock secara modelling itu kurang sesuai PSR-4 (contoh : KYC.php --> refer ke tabel K_Y_C)

.
└── satusehat-integration/
└── src/
├── Exception/
│ ├── FHIR/
│ │ ├── FHIRException.php
│ │ ├── FHIRInvalidPropertyValue.php
│ │ └── ....
│ ├── Terminology/
│ │ ├── TerminologyException.php
│ │ └── .... (bila ada)
│ ├── Models/
│ │ ├── SatusehatLogException.php (bila ada)
│ │ └── SatusehatTokenException.php (bila ada)
│ └── Helper/
│ ├── KycException.php (bila ada)
│ └── OAuthClient.php (bila ada)
├── Models (untuk proses yang perlu CRUD)/
│ ├── SatusehatLog.php
│ └── SatusehatToken.php
├── FHIR/
│ ├── Patient.php
│ ├── Practitioner.php
│ └── ...... (FHIR Object lainnya)
├── Terminology/
│ ├── Icd10.php
│ ├── Icd9cm.php
│ ├── Kfa.php (need to refactor jadi camel case instead)
│ ├── KodeWilayahIndonesia.php
│ └── Loinc.php (future development)
├── Kyc.php (Helper function, need help untuk refactor ini jadi camel case)
├── OAuthClient.php (Helper function)
└── SatusehatIntegrationServiceProvider.php (provider php file)

@ivanwilliammd ivanwilliammd linked a pull request Apr 10, 2024 that will close this issue
@ivanwilliammd ivanwilliammd linked a pull request Apr 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants