Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Provider.UploadURL #56

Closed
applejag opened this issue Sep 7, 2021 · 0 comments · Fixed by #82
Closed

Remove Provider.UploadURL #56

applejag opened this issue Sep 7, 2021 · 0 comments · Fixed by #82
Assignees
Labels
enhancement New feature or request
Projects

Comments

@applejag
Copy link
Contributor

applejag commented Sep 7, 2021

Old and unused field on the provider model.

For GitHub, the API URL is https://api.github.com/, but to upload assets to a release you use https://uploads.github.com. This URL is however provided by the "Create a release" endpoint and should be able to be provided from there instead.

I've not researched the other providers, but I do know that the upload URL field is unused throught Wharf.

Migrations are needed. GORM doesn't removes columns automatically, it only adds them automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants