Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need automated testing via go test #43

Closed
Tracked by #75
applejag opened this issue Nov 3, 2021 · 0 comments · Fixed by #45
Closed
Tracked by #75

Need automated testing via go test #43

applejag opened this issue Nov 3, 2021 · 0 comments · Fixed by #45
Assignees
Labels
enhancement New feature or request
Projects

Comments

@applejag
Copy link
Contributor

applejag commented Nov 3, 2021

Based on iver-wharf/iver-wharf.github.io#75

Need to run Go tests and goimports formatting tests on commits and pull requests automatically.

As Wharf cannot do this yet, we should aim at using GitHub Actions.

Either we use the starter-workflow for Go https://github.com/actions/starter-workflows/blob/1d8891efc2151b2290b1d93e8489f9b1f41bd047/ci/go.yml which simply runs go test

Or we could look into a better integrated solution that could report failing tests as annotations inside the pull requests, such as:

@applejag applejag added the enhancement New feature or request label Nov 3, 2021
@applejag applejag self-assigned this Nov 3, 2021
@applejag applejag added this to To do in Backlog via automation Nov 3, 2021
Backlog automation moved this from To do to Done Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant