Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GainPeak #181

Open
iver56 opened this issue Mar 17, 2022 · 7 comments
Open

Implement GainPeak #181

iver56 opened this issue Mar 17, 2022 · 7 comments
Assignees

Comments

@iver56
Copy link
Owner

iver56 commented Mar 17, 2022

Something that turns the gain up and then down, almost like a sound source that drives by

This is a specialization of #53 (comment)

@atamazian
Copy link
Contributor

Which parameters should be available to be set? Max gain and its position?

@iver56
Copy link
Owner Author

iver56 commented May 27, 2022

I guess it should randomize at least these things:

  • the difference between min gain and max gain
  • "the wideness" of the gain curve (think like: how fast does the sound source drive by)
  • the offset of the gain curve. E.g. the peak of the gain curve can also be before the start or after the end

Bonus:

  • The shape of the gain curve. Could be triangle, could be gaussian, could be "cosine interpolation"...
  • Whether the gain curve is defined on a logarithmic scale (decibel, like those faders you'll see on physical mixers) or not

@atamazian
Copy link
Contributor

Can you assign this issue to me? I'll try to do it.

@iver56
Copy link
Owner Author

iver56 commented May 29, 2022

Great! Done

@atamazian
Copy link
Contributor

Should we let user specify min_gain, or should we set it to some constant value?

@iver56
Copy link
Owner Author

iver56 commented Jun 6, 2022

I guess the most important thing is the difference between the minimum gain and the maximum gain.

In the future I want to establish a common post-gain pattern that can compensate: #171

Thanks for the PR by the way! I will have a look at soon-ish :)

@atamazian
Copy link
Contributor

atamazian commented Jun 6, 2022

Thanks! As for now, I've have min_gain specified by the user.

@iver56 iver56 assigned iver56 and unassigned atamazian Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants