Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multichannel audio data #55

Closed
iver56 opened this issue Sep 11, 2020 · 6 comments
Closed

Add support for multichannel audio data #55

iver56 opened this issue Sep 11, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@iver56
Copy link
Owner

iver56 commented Sep 11, 2020

shape=(num_samples, num_channels) should be supported as well as shape=(num_samples,)

@francislata
Copy link

When is the expected delivery for this one @iver56?

@iver56
Copy link
Owner Author

iver56 commented Sep 17, 2020

Hi Francis, and thanks for your interest in this. I have no clear plan for this. I guess it's whenever I have time. If you want to speed this up, contributions are welcome!

By the way, yesterday I figured that shape=(num_channels, num_samples) is also sometimes something people use for multichannel audio. Should we support both?

@iver56 iver56 added the enhancement New feature or request label Sep 17, 2020
@iver56
Copy link
Owner Author

iver56 commented Sep 17, 2020

Librosa (see librosa/librosa#1130) will use the convention (num_channels, num_samples). I think I prefer this.

The other dimension ordering, (num_samples, num_channels), is used when loading and saving multichannel wav, where stereo samples are interleaved.

@francislata
Copy link

@iver56 - I think sticking to one specific ordering like num_channels, num_samples just like in librosa would be much better.

@iver56
Copy link
Owner Author

iver56 commented Sep 18, 2020

Agreed.

I have started some basic work on multichannel audio support here: 59707fd

Contributions are welcome

@iver56
Copy link
Owner Author

iver56 commented Nov 13, 2020

Gain, PolarityInversion and PeakNormalization support multichannel audio now. I guess we can create separate issues for adding multichannel support to other transforms.

@iver56 iver56 closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants