cmake template: remove panic_immediate_abort for new idf versions #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the other hand it erases 100 to 200K from the final binary. |
|
Perhaps we need a |
build-std-features=panic_immediate_abort causes panics to not print their error messages which is a bad developer experience. Similar to the Cargo template, do not set this flag for newer espidf versions. Introduce a .cargo/config.toml to the cmake template to make more similar to the cargo template.
benhansen-io
force-pushed
the
cmake-panic-fix
branch
from
6f55c70
to
cacf492
Compare
|
I introduced a minimal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-std-features=panic_immediate_abort causes panics to not print
their error messages which is a bad developer experience. Similar to
the Cargo template, do not set this flag for newer espidf versions.