Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadFiles works, LoadURLs error in demo and custom implementation #1008

Closed
jjreicher opened this issue Oct 1, 2021 · 4 comments
Closed

LoadFiles works, LoadURLs error in demo and custom implementation #1008

jjreicher opened this issue Oct 1, 2021 · 4 comments
Labels
question Further information is requested
Milestone

Comments

@jjreicher
Copy link

  1. In my implementation, the header is parsed just fine, but the image never displays. There is no error message. Other cases work fine! I have 5-6 similar examples though with this same issue. I'm using loadURLs.
  2. In the online jQuery demo viewer, if I load the case with the file uploader...it works! Displays perfectly.
  3. In the same demo viewer, if I load via URL--the image won't show. I get error messages ("not valid DICOM", etc) but they don't make much sense.

Emailed a sample file. Any help greatly appreciated!

@ivmartel ivmartel added the question Further information is requested label Oct 4, 2021
@ivmartel ivmartel added this to the 0.30.0 milestone Oct 4, 2021
@ivmartel
Copy link
Owner

ivmartel commented Oct 4, 2021

I got your email, thanks, I'll look into it!

@jjreicher
Copy link
Author

jjreicher commented Oct 4, 2021

Ok I figured out the source of the problem at least...! Still not sure why the difference between the two loading methods though.

Basically in the checks for "vr" if there is a custom DICOM field, and if that field has an empty vr, you'll get some nonsense errors and the page won't load. If you change isOtherVR to true, the file works. I think the function instead needs to first check if empty and accept/pass if so.

Hopefully I can issue a commit if confirmed that this works and doesn't break anything else, but I think this is the issue.

@ivmartel
Copy link
Owner

The isOtherVR variable you mention is there: dicomElementsWrapper.js#L231.

@ivmartel
Copy link
Owner

ivmartel commented Oct 15, 2021

The problem seems to be related to the tag (0018,9445) (dictionary.js#L1179)... It is one of these placeholders: "For some Data Elements, no Name or Keyword or VR or VM is specified; these are "placeholders" that are not assigned but will not be reused." (ref: current/output/html/part06.html).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants