Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Application tool API #1203

Closed
ivmartel opened this issue Aug 3, 2022 · 1 comment
Closed

Simplify Application tool API #1203

ivmartel opened this issue Aug 3, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
0.31.0

Comments

@ivmartel
Copy link
Owner

ivmartel commented Aug 3, 2022

The current application tool api uses tool specific methods to set their properties. This must be avoided to avoid adapting the application for each new tool. One single method must be used, it will take an object as argument and pass it directly to the current tool without any modifications.
@ivmartel ivmartel added the enhancement New feature or request label Aug 3, 2022
@ivmartel ivmartel added this to the 0.31.0 milestone Aug 3, 2022
@ivmartel
Copy link
Owner Author

The app class now provides a setToolFeatures (application.js#L979), that passes its object argument to the current tool. The tool then handles its content. See how the draw tool does it: draw.js#L815.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.31.0
Development

No branches or pull requests
1 participant
@ivmartel