Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drawlayer bug when changing data view #1423

Closed
ychyss opened this issue Jun 27, 2023 · 1 comment
Closed

drawlayer bug when changing data view #1423

ychyss opened this issue Jun 27, 2023 · 1 comment
Labels
bug Something isn't working
Milestone
0.33.0

Comments

@ychyss
Copy link

ychyss commented Jun 27, 2023

I test this bug on dwv/tests/pacs/viewer.js example. version 0.32.0

Steps:

  1. Open series in single view
  2. Select tool 'Draw'
  3. Draw a rectangle
  4. Change Layout to MPR
  5. Select tool 'Scroll'
  6. Scroll any view

image

got error: can't access property "getDrawController", layerGroup.getActiveDrawLayer() is undefined

image

The stack info is here:

image
@ivmartel ivmartel added the bug Something isn't working label Jun 27, 2023
@ivmartel ivmartel added this to the 0.33.0 milestone Jun 27, 2023
@ivmartel ivmartel mentioned this issue Jun 30, 2023
Closed
@ivmartel
Copy link
Owner

ivmartel commented Jun 30, 2023 •
edited
Loading

The viewer does not save the roi and if it did, it would need to know if it can be drawn on the new layer. This seems a bit complicated, for now I will just try to make it not crash.

@ivmartel ivmartel mentioned this issue Aug 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.33.0
Development

No branches or pull requests
2 participants
@ivmartel @ychyss