Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data change bug in viewer #1424

Closed
ychyss opened this issue Jun 27, 2023 · 3 comments
Closed

data change bug in viewer #1424

ychyss opened this issue Jun 27, 2023 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@ychyss
Copy link

ychyss commented Jun 27, 2023

I test this bug on dwv/tests/pacs/viewer.js example. version 0.32.0

Steps:

  1. Select one series (vhf head data) in single layout
  2. Do some interations(scroll it or click it)
  3. Change view layout to MPR
  4. Press 'Reset Viewer'
  5. Open new series (vhf hip data) in MPR layout

the view layer looks like at wrong direction ... (no error log. even when I open series in MPR layout first time)
image

  1. Click view layout to single
    got error: Cannot initialise layer with data id: 0

image

the stack info is here:
image

I also found this bug in my project, and I avoid this bug by deleting whole dwvApp object and store the dicom files data into a custom array, and then set new data into a new dwvApp instance manually(do not use reset).

@ivmartel ivmartel added the bug Something isn't working label Jul 4, 2023
@ivmartel ivmartel added this to the 0.33.0 milestone Jul 4, 2023
@ivmartel
Copy link
Owner

ivmartel commented Jul 4, 2023

Sorry, I can't reproduce. What do you mean by 'Reset Viewer' in step 4?

@ychyss
Copy link
Author

ychyss commented Jul 4, 2023

Sorry for that, I mean call app.reset() method using a button.(https://ivmartel.github.io/dwv/doc/stable/App.html#reset)

@ivmartel
Copy link
Owner

ivmartel commented Jul 4, 2023

Ok got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants