Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL with hash part is not parsed correctly #146

Closed
delx opened this issue Apr 29, 2015 · 0 comments
Closed

URL with hash part is not parsed correctly #146

delx opened this issue Apr 29, 2015 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@delx
Copy link

delx commented Apr 29, 2015

DWV (master) doesn't load if it's called with the following URL that has a hash part:

http://dwv/viewers/mobile/index.html?input=url#/path/path

I think it's because in application.js the following code is used:

var query = dwv.html.getUriParam(window.location.href);

Here window.location.href includes the hash part of the URL, but the underlying function dwv.utils.splitQueryString doesn't handle the hash part. Instead it simply treats the hash part as value of the input parameter.

@ivmartel ivmartel added the bug Something isn't working label May 6, 2015
@ivmartel ivmartel added this to the 0.10.0 milestone May 6, 2015
@ivmartel ivmartel self-assigned this May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants