Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check memory usage for second image load #397

Closed
ivmartel opened this issue Sep 25, 2017 · 6 comments
Closed

Check memory usage for second image load #397

ivmartel opened this issue Sep 25, 2017 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@ivmartel
Copy link
Owner

Memory usage increases when loading a second image on top of another. This should not be the case. It is the purpose of the application 'reset' method to do the clean up, maybe it is missing something.

Originates from #382.

@ivmartel ivmartel added the enhancement New feature or request label Sep 25, 2017
@ivmartel ivmartel added this to the 0.22.0 milestone Sep 25, 2017
@ivmartel ivmartel modified the milestones: 0.22.0, 0.23.0 Nov 20, 2017
@ddbxyrj
Copy link

ddbxyrj commented Dec 14, 2017

I found when loading 1000 dicom.each on have the size of 210k 244MB for total. chome and firefox will cursh(even if load from loacal disk). chrome will crush at the 600. firefox will stop and don't load serveral pictures. and use 6GB memory. vivaldi will spend 1G memory load all pictures. All of them spent much time to load.(decoding?) Is this problem cause by hardwave limitation or there are some room to optimize? Depend on different performance of brower, I thought many be we can do some optimize. Can you give me some hits? Thank a lot.

@KayLamerigts
Copy link

KayLamerigts commented Dec 28, 2017

I am trying to load a study of ~200 instances. The total size is ~85 MB.

The JavaScript heap memory does not exceed the expected size (~150MB), but the tab's private memory does (~1.5GB).

The culprit seems to be dicomBufferToView:64, chrome's private memory increases each time this line is called. The amount varies up to 5 MB.

[edit] This was wrong. It is due to #442.

@ddbxyrj
Copy link

ddbxyrj commented Jan 3, 2018

Could it be solved by limit how many dicom same time? Just, 200->0-50,51-100. But don't refresh

@ivmartel
Copy link
Owner Author

ivmartel commented Mar 2, 2018

#442 is now fixed! Did it help solve your issue?

@ivmartel ivmartel modified the milestones: 0.23.0, 0.24.0 Mar 8, 2018
@ddbxyrj
Copy link

ddbxyrj commented Apr 1, 2018

yes. dwv will not crash. However may I proposal an enhancement. If we loading 1000 dicom files, first 30 dicom may loaded and appended quickly, just say 1ms/file. It will become slow down beyond 100 file obviously. So if we can just dynamically load forward 20 files and backward 20 files relative to index of user watching, may be it can solve problems about different hardware of computer. I look up code, found thread->append->getsliceIndex. I want to finish this work. But it need to use append function and delete canvas(for memory usage). Haha, It already spent me 2 days, no clues:) Can you give me some advices? Thank you

@ivmartel ivmartel modified the milestones: 0.24.0, 0.25.0 Apr 26, 2018
@ivmartel ivmartel modified the milestones: 0.25.0, 0.26.0 Oct 2, 2018
@ivmartel
Copy link
Owner Author

ivmartel commented Apr 5, 2019

Follow #342 for progress on your proposal.

Closing for now, feel free to comment if you need.

@ivmartel ivmartel closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants