Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DICOM Compliance #449

Closed
tguiot opened this issue Jan 24, 2018 · 1 comment
Closed

DICOM Compliance #449

tguiot opened this issue Jan 24, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone
0.23.0

Comments

@tguiot
Copy link

tguiot commented Jan 24, 2018 •
edited by ivmartel
Loading

Hi,

we've been using dwv to de-identify images. The dicom writer is not fully DICOM-compliant. I spotted two mistakes:

  1. Implementation Class UID (0002,0012) contains invalid characters: "1.2.826.0.1.3680043.9.7278.1.0.22.0-beta". The "-beta" part should not be there, only numbers 0-9 and the dot are accepted. See http://dicom.nema.org/medical/Dicom/current/output/chtml/part05/sect_6.2.html#para_abd621c3-13e4-473e-98c9-961f4c69154c

  2. Implementation version name (0002,0013) is of odd length: in my case "DWV_0.22.0-beta" is 15 characters long and the NULL character should have been added to have an even length.

Cheers
Thomas
@ivmartel ivmartel added the enhancement New feature or request label Jan 25, 2018
@ivmartel ivmartel added this to the 0.23.0 milestone Jan 25, 2018
@ivmartel
Copy link
Owner

Thanks Thomas,

  1. I'm not expecting the betas to be used "officially", that's why I left the "-beta"
  2. Good point, I'll try to fix this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.23.0
Development

No branches or pull requests
2 participants
@ivmartel @tguiot