Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slow processing speed when loading series with more than 100 Slices #559

Closed
frickt opened this issue Aug 29, 2018 · 5 comments
Closed

slow processing speed when loading series with more than 100 Slices #559

frickt opened this issue Aug 29, 2018 · 5 comments
Labels
enhancement New feature or request
Milestone
0.26.0

Comments

@frickt
Copy link
Contributor

frickt commented Aug 29, 2018

Unnecessary buffer merging.
@frickt
Copy link
Contributor Author

frickt commented Aug 29, 2018

fixed with #558

@ivmartel ivmartel mentioned this issue Sep 3, 2018
Closed
@ivmartel ivmartel added the enhancement New feature or request label Sep 3, 2018
@ivmartel ivmartel added this to the 0.25.0 milestone Sep 3, 2018
@frickt
Copy link
Contributor Author

frickt commented Sep 5, 2018

Is there a reason why the buffer contains all slices?
to improve the performance even further, we could change the big buffer to a list of pointers to the original buffer, so we could omit the coping of all slices, what do you think?

@ivmartel
Copy link
Owner

ivmartel commented Sep 5, 2018

No real reason, avoiding the copy looks like a good idea!

@frickt
Copy link
Contributor Author

frickt commented Sep 6, 2018

fixed with #569
#558 can be discarded

@ivmartel ivmartel modified the milestones: 0.25.0, 0.26.0 Oct 2, 2018
@ivmartel
Copy link
Owner

ivmartel commented Apr 5, 2019

Follow #569 for progress.

@ivmartel ivmartel closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.26.0
Development

No branches or pull requests
2 participants
@ivmartel @frickt