Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use container size as reference #579

Closed
ivmartel opened this issue Oct 2, 2018 · 0 comments
Closed

Use container size as reference #579

ivmartel opened this issue Oct 2, 2018 · 0 comments
Labels
breaking Breaking change enhancement New feature or request
Milestone

Comments

@ivmartel
Copy link
Owner

ivmartel commented Oct 2, 2018

The current code exposes a fitToWindow options to fit the size of the viewer to the containing window. This should be the responsibility of the calling app: the viewer should fit to the container div and the app set the div size to the window one or not. In this case the option would not be needed any more and could be removed.

This can be useful in a full screen scenario where the viewer is part of a page at a reduced size and provides a full screen option where you want it to be as wide as possible.

@ivmartel ivmartel added the enhancement New feature or request label Oct 2, 2018
@ivmartel ivmartel added this to the 0.25.0 milestone Oct 2, 2018
@ivmartel ivmartel added the breaking Breaking change label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant