Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node deprecation #614

Closed
ivmartel opened this issue Dec 13, 2018 · 1 comment
Closed

Node deprecation #614

ivmartel opened this issue Dec 13, 2018 · 1 comment
Labels
bug Something isn't working
Milestone
0.28.0

Comments

@ivmartel
Copy link
Owner

Builds run with Node 8 output a deprecation warning after testing: (node:4530) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.

Builds run with Node 10 fail after testing with a Fatal error: Callback must be a function. Commit 20c16e4 downgraded Node to fix the build, a better solution must be found.
@ivmartel ivmartel added the enhancement New feature or request label Dec 13, 2018
@ivmartel ivmartel added this to the 0.26.0 milestone Dec 13, 2018
@ivmartel ivmartel added bug Something isn't working and removed enhancement New feature or request labels Dec 13, 2018
@ivmartel ivmartel modified the milestones: 0.26.0, 0.28.0 Apr 5, 2019
@ivmartel
Copy link
Owner Author

ivmartel commented Apr 5, 2020

This seems related to PhantomJs... #725 fixed it, cf this build after 1861b55.

Node was updated to lts on Travis at 15ad6a8.

@ivmartel ivmartel closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.28.0
Development

No branches or pull requests
1 participant
@ivmartel