New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gui specific code #679

Closed

ivmartel opened this issue Sep 5, 2019 · 1 comment

Labels

Milestone

Owner

ivmartel commented Sep 5, 2019

GUI code should go in dwvs' client code to limit dwv responsibilities.

ivmartel added the enhancement label

ivmartel added this to the 0.27.0 milestone

ivmartel mentioned this issue

679 remove gui #696

Merged

ivmartel closed this as completed

Owner Author

ivmartel commented Jan 22, 2020

With this change, comes a big change in the logic of the app, dwv tries to do as less as possible html manipulation.

Concretely, this means:

tools do not handle their gui anymore
the application does not initialise the tool guis
no more overlay setting while loading data
(in application.js) no more public event handlers (apart from the key handler, it could also go)

Conclusion, way less gui code in the gui folder and a more focused app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment