Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using PhantomJS #719

Closed
ivmartel opened this issue Mar 30, 2020 · 1 comment · Fixed by #725
Closed

Stop using PhantomJS #719

ivmartel opened this issue Mar 30, 2020 · 1 comment · Fixed by #725
Labels
enhancement New feature or request
Milestone
0.28.0

Comments

@ivmartel
Copy link
Owner

dwv should stop using PhantomJs for headless browser testing because:

  • PhantomJs gives strange errors in Travis
  • the project has been archived in March 2018 (see 15344

PhantomJs is the headless browser used in the CI testing chain. At the moment, the project uses grunt-qunit-istanbul (that includes PhantomJs). The original repository (grunt-contrib-qunit) has moved to using Puppeteer but not this one...

One solution could be to use the test runner called Karma which seems to be compatible with QUnit tests, can launch a headless browser and generate coverage information.
@ivmartel ivmartel added the enhancement New feature or request label Mar 30, 2020
@ivmartel ivmartel added this to the 0.28.0 milestone Mar 30, 2020
@ivmartel
Copy link
Owner Author

ivmartel commented Apr 4, 2020

Dependency updates to latest versions are failing when using Phantom, see konva 4 build and i18next 19 build.

@ivmartel ivmartel linked a pull request Apr 4, 2020 that will close this issue
719 stop phantom #725
Merged
@ivmartel ivmartel mentioned this issue Apr 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.28.0
Development

Successfully merging a pull request may close this issue.

719 stop phantom ivmartel/dwv
1 participant
@ivmartel