Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp-babel Sourcemaps not working with TypeScript 2.0 via gulp-typescript #441

Closed
ijabit opened this issue Oct 14, 2016 · 3 comments
Closed

Comments

@ijabit
Copy link

ijabit commented Oct 14, 2016

babel/gulp-babel#99

I don't know if this issue is for gulp-typescript or gulp-babel, so I posted it in both :)

You can read the other post, but basically after upgrading gulp-typescript to v3.0.2, it now uses backslashes instead of forward slashes in the sourceMap.file property. So if your file is in a subdirectory, this breaks sourcemaps when processing through another layer which is using vinyl-sourcemaps-apply (like gulp-babel is). I think gulp-babel should handle the backslashes, but I also don't think gulp-typescript should be using backslashes since apparently vinyl-sourcemaps-apply can't handle them. You are the experts, let me know who is in the wrong here. Is it gulp-typescript, gulp-babel, or vinyl-sourcemaps-apply, or all of the above??

@ijabit
Copy link
Author

ijabit commented Oct 20, 2016

Bump

@ivogabe
Copy link
Owner

ivogabe commented Oct 22, 2016

Sorry, didn't have time to take a look at this earlier. Should be fixed with the referenced commit.

@ijabit
Copy link
Author

ijabit commented Nov 6, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants