Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge port scripts and host scripts #117

Closed
p-l- opened this issue Aug 17, 2015 · 0 comments
Closed

Merge port scripts and host scripts #117

p-l- opened this issue Aug 17, 2015 · 0 comments
Assignees

Comments

@p-l-
Copy link
Member

p-l- commented Aug 17, 2015

Managing both port and host scripts makes the code more complicated and, more importantly, make some request we make less efficient (because less capable of using MongoDB indexes).

We should either manage all scripts in a central list of nested documents:

{
    "ports": [{"proto": "tcp", "port": 80, [...]}, [...]],
    "scripts": [
        {"port": 80, "proto": "tcp", "id": "http-title", "output": [...]},
        {"host": True, "id": "firewalk", "output": [...]},
    ],
}

Or create a fake nested document in ports array:

{
    "ports": [
        {"proto": "tcp", "port": 80, "scripts": [{"id": "http-title", "output": [...]}, [...]] [...]},
        {"host": True, "scripts": [{"id": "firewalk", "output": [...]}, [...]]},
    ],
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant