Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for --adapter-port (upstream PR not merged) #9

Closed
mzpqnxow opened this issue Oct 19, 2023 · 3 comments
Closed

Fix for --adapter-port (upstream PR not merged) #9

mzpqnxow opened this issue Oct 19, 2023 · 3 comments

Comments

@mzpqnxow
Copy link

Hey there @p-l-

As usual, thanks for maintaining this fork, it's made my life so much easier

FYI, I just submitted robertdavidgraham#738 upstream

This adds the saving of --adapter-port value, which was simply missing from the masscan_echo function

With this you can properly resume a scan that uses --adapter-port/--source-port and you can also see more correct output when using --echo (since they share a function, just use a different FILE * (paused.conf vs stderr)

I tried not to bork any whitespace this time, but please let me know if you prefer any changes (or feel free to make said changes yourself)

Thanks!

@mzpqnxow
Copy link
Author

Also- should I send the PR here? I don't know if you can merge the upstream PR or if it's easier to have the PR directly to the fork

I'll send here and you can close it if it's unnecessary

@mzpqnxow
Copy link
Author

Created #10 if that's easier

@mzpqnxow mzpqnxow changed the title Fix for --adapter-port (PR sent upstream) Fix for --adapter-port (upstream PR not merged) Oct 19, 2023
@p-l-
Copy link
Member

p-l- commented Oct 19, 2023

Thanks a lot! It's better for me if you create a PR here too, as you did.

@p-l- p-l- closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants