Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ParentEnvironment from EmitCtx #51

Open
iwillspeak opened this issue Nov 20, 2021 · 0 comments
Open

Remove ParentEnvironment from EmitCtx #51

iwillspeak opened this issue Nov 20, 2021 · 0 comments
Labels
feature New feature or request up for grabs Shout out and claim this issue

Comments

@iwillspeak
Copy link
Owner

Only make instance methods on the environment iff the parent is captured.

The current emit context keeps track of the parent context to handle the case where the current method doesn't have an environment but the parent method does. In that case we still currently emit the method as an instance method on the parent's environment. There doesn't seem to be a need to do so however. instead we could emit it as a static metod on the current library type.

@iwillspeak iwillspeak added feature New feature or request up for grabs Shout out and claim this issue labels Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request up for grabs Shout out and claim this issue
Projects
None yet
Development

No branches or pull requests

1 participant