Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing package on conda-forge #21

Closed
francbartoli opened this issue Sep 21, 2020 · 6 comments · Fixed by #37
Closed

Publishing package on conda-forge #21

francbartoli opened this issue Sep 21, 2020 · 6 comments · Fixed by #37

Comments

@francbartoli
Copy link
Contributor

Hi @iwpnd, this is a great package! Unfortunately, it is not available on conda-forge while flashtext can be found.
I'm building a library around it and I can only fetch packages from conda-forge so I'm wondering if you might accept PR to publish on conda-forge eventually.
For now the workaround is to embed all flashgeotext as a module statically but I would love to declare it in the dependencies.

@iwpnd
Copy link
Owner

iwpnd commented Sep 21, 2020

Hi @francbartoli, I'd be happy to accept your PR on this. I'd learn a thing or two I believe. :)

@francbartoli
Copy link
Contributor Author

Hi @iwpnd, sorry for the late follow up on this. I'm now ready to perform it so I'm going to start the procedure.

By the way, I've just published pyflashtext to conda-forge, which is a fork of the original flashtext. I had to take this decision because the codebase contained the fuzzy search but the maintainer wasn't able to publish a new version of the package for a long time (see this issue).

I'd like to integrate the fuzzy search functionality as optional to flashgeotext, what do you think?

@francbartoli
Copy link
Contributor Author

I've started the pull request for conda-forge conda-forge/staged-recipes#14513.

@iwpnd can you please post a comment there to just say you are willing to be listed as maintainer?

@iwpnd
Copy link
Owner

iwpnd commented Apr 9, 2021

I followed the discussion around the fuzzy search. Sounds like a good addition but would decrease performance depending on the edit distance? Would've to be an option in this case.

@iwpnd
Copy link
Owner

iwpnd commented Apr 9, 2021

@francbartoli done

@francbartoli
Copy link
Contributor Author

Our feedstock repo has been created on the conda-forge organization and the package is available to install in conda.

@iwpnd you can review the pr at your earliest convenience and then close this once that is merged.

@iwpnd iwpnd closed this as completed in #37 Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants