Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from enum_primitive to num-enum? #57

Open
waywardmonkeys opened this issue Oct 14, 2023 · 1 comment
Open

Switch from enum_primitive to num-enum? #57

waywardmonkeys opened this issue Oct 14, 2023 · 1 comment

Comments

@waywardmonkeys
Copy link
Contributor

enum_primitive hasn't been maintained in years and is an old style macro.

We could migrate to enum_derive_primitive or num-enum.

It seems like num-enum is more actively maintained and is part of the larger ecosystem.

Before doing this, we'll want some PRs to land (including one that isn't submitted yet) to avoid merge conflicts.

@mrghosti3
Copy link
Contributor

What purpose does any of those crates perform? To me it just simpler to implement From trait for the enums that need to be converted from numbers.

On other note, enum_derive_primitive looks better, as it is simpler and with lesser dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants