Drop official support for outdated gems

- Bootstrap ~> 3.2 - FontAwesome ~> 4.2 - Jekyll ~> 2.0
envygeeks · Sep 14, 2014 · 98bd7af · davetapley · May 9, 2015 · ixti
1 parent ba17244
commit 98bd7af
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 14 deletions.
diff --git a/Gemfile b/Gemfile
@@ -3,8 +3,8 @@ source "https://rubygems.org"
 gem "compass"
 gem "bourbon"
 gem "neat"
-gem "bootstrap-sass"
-gem "font-awesome-sass"
+gem "bootstrap-sass", "~> 3.2"
+gem "font-awesome-sass", "~> 4.2"
 
 # compass fails with SASS than 3.3+
 # https://github.com/chriseppstein/compass/issues/1513

diff --git a/gemfiles/Gemfile.bootstrap-pre-3.2 b/gemfiles/Gemfile.bootstrap-pre-3.2
diff --git a/gemfiles/Gemfile.fontawesome-pre-4.2 b/gemfiles/Gemfile.fontawesome-pre-4.2
diff --git a/gemfiles/Gemfile.jekyll-1.0 b/gemfiles/Gemfile.jekyll-1.0
diff --git a/jekyll-assets.gemspec b/jekyll-assets.gemspec
@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(/^(test|spec|features)\//)
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "jekyll",    ">= 1.0.0", "< 3.0.0"
+  spec.add_dependency "jekyll",    "~> 2.0"
   spec.add_dependency "sprockets", "~> 2.10"
   spec.add_dependency "sprockets-sass"
   spec.add_dependency "sprockets-helpers"

diff --git a/lib/jekyll-assets/bootstrap.rb b/lib/jekyll-assets/bootstrap.rb
@@ -1,8 +1,7 @@
 require "sprockets"
 
 gemspec = Gem::Specification.find_by_name "bootstrap-sass"
-subpath = Gem::Version.new("3.2") <= gemspec.version ? "" : "vendor"
 
 %w[images fonts javascripts stylesheets].each do |asset|
-  Sprockets.append_path File.join(gemspec.gem_dir, subpath, "assets", asset)
+  Sprockets.append_path File.join(gemspec.gem_dir, "assets", asset)
 end
diff --git a/lib/jekyll-assets/font-awesome.rb b/lib/jekyll-assets/font-awesome.rb
@@ -1,8 +1,7 @@
 require "sprockets"
 
 gemspec = Gem::Specification.find_by_name "font-awesome-sass"
-subpath = Gem::Version.new("4.2") <= gemspec.version ? "" : "vendor"
 
 %w[fonts stylesheets].each do |asset|
-  Sprockets.append_path File.join(gemspec.gem_dir, subpath, "assets", asset)
+  Sprockets.append_path File.join(gemspec.gem_dir, "assets", asset)
 end
diff --git a/spec/fixtures/_assets/vendor/with_bootstrap.css.sass b/spec/fixtures/_assets/vendor/with_bootstrap.css.sass
@@ -0,0 +1 @@
+@import "bootstrap"
diff --git a/spec/lib/jekyll-assets/bootstrap_spec.rb b/spec/lib/jekyll-assets/bootstrap_spec.rb
@@ -3,6 +3,7 @@
 
 RSpec.describe "Bootstrap integration" do
   it "globally appends bootstrap paths into Sprockets environment" do
-    expect(@site.assets["bootstrap.css"].to_s).to match(/bootstrap\//)
+    expect(@site.assets["vendor/with_bootstrap.css"].to_s)
+      .to match(/bootstrap\//)
   end
 end