Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript/CoffeeScript not triggering Jekyll to rebuild when changed #115

Closed
tombell opened this issue Nov 26, 2014 · 13 comments
Closed

JavaScript/CoffeeScript not triggering Jekyll to rebuild when changed #115

tombell opened this issue Nov 26, 2014 · 13 comments
Milestone

Comments

@tombell
Copy link

tombell commented Nov 26, 2014

When editing SCSS files, Jekyll notices these changes and rebuilds. However when editing JS/CS, Jekyll doesn't rebuild.

I don't know if this is an issue with jekyll or jekyll-assets.

@ixti
Copy link
Contributor

ixti commented Nov 26, 2014

Can you provide your _config.yml and files tree related to your issue?

@tombell
Copy link
Author

tombell commented Nov 26, 2014

# rendering markdown
markdown: redcarpet
redcarpet:
  extensions: [smart, autolink]

# syntax highlighting
highlighter: 'pygments'

exclude: [ 'bin', 'Gemfile', 'Gemfile.lock', 'README.md', 'script', 's3_website.yml' ]
gems: ['jekyll-assets', 'jekyll-redirect-from']

# site metadata
name: redacted
url: https://redacted.com

# assets
assets:
  js_compressor:
  css_compressor:

# categories
category_archive:
  path: '/blog/category'
  paginate: 5
  paginate_path: 'blog/category/:category/page:num'

# pagination
paginate: 5
paginate_path: "blog/page:num"

# collections
collections:
  jobs:
    output: true
    permalink: /jobs/position/:path/
  support_articles:
    output: true
    permalink: /support/:title/

# disqus comments
disqus_shortname: 'redacted'
  • _assets
    • javascripts
      • vendor/*.js
      • *.js.coffee
      • app.coffee
    • stylesheets
      • vendor/*.css
      • *.scss

@ixti
Copy link
Contributor

ixti commented Dec 7, 2014

What jekyll version are you using? Because it works ok for me on 2.1.1.

@tombell
Copy link
Author

tombell commented Dec 7, 2014

jekyll 2.4.0

@jameskerr
Copy link

I am also having this problem.

@ixti ixti self-assigned this Feb 10, 2015
@peplin
Copy link

peplin commented Feb 13, 2015

Here's a "me too" - anything I can provide to help debug this?

@ixti
Copy link
Contributor

ixti commented Feb 13, 2015

I think I know where this bug might come from - I just need to recheck.

@peplin
Copy link

peplin commented Mar 4, 2015

If you could describe what you think might be happening, I might be able to help debug. Thanks!

@ixti ixti modified the milestone: v1.0.0 Mar 14, 2015
@peplin
Copy link

peplin commented May 8, 2015

I'm still having this issue with v1.0.0.pre.alpha1.

@envygeeks envygeeks modified the milestones: v2.0.0, v1.0.0 Jul 17, 2015
@envygeeks
Copy link
Owner

Could this have been a Jekyll 2.4 problems? AFAIW it would be Jekyll that triggers the rebuild, unless there was a bad mtime cache (which was the cause of a lot of other problems when it came to importing assets independent of sprockets through SASS) which meant that even if there was a change detected a rebuild of the asset was never done. We resolved this in HEAD (2.0.0) by switching to a digested cache and using Sprockets 3 file cache so we could always pull a fresh asset with find_asset and redigest against the cache.

/cc @parkr

In Jekyll3 we have no problems with jekyll-assets/HEAD (be catious in using it, it's not fully compatible with 1.0.0 yet) on the dozen or so sites I currently maintain.

@parkr
Copy link

parkr commented Jul 26, 2015

Jekyll does trigger the rebuild via jekyll-watch. It is instructed to listen to everything, excepting things in your exclude configuration directive. Do the CS files contain any of the items in exclude, such as script (based on above)? For example, _assets/coffeescript/main.coffee will be ignored because exclude's are turned into a global /regexp/.

@envygeeks
Copy link
Owner

By triggering the rebuild I mean once Jekyll rebuilds itself we are triggered through that in 1.0.0 and in 2.0.0 we hook into post and pre hooks to get triggered.

@envygeeks
Copy link
Owner

This has been fixed for a while AFAIW, closing this out of this milestone, if it's not the case on 2.0.0 then please add a message on this ticket and I'll investigate the regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants