Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strictly ordered queues usage on Sidekiq 4 #13

Closed
ixti opened this issue May 16, 2016 · 1 comment
Closed

Fix strictly ordered queues usage on Sidekiq 4 #13

ixti opened this issue May 16, 2016 · 1 comment

Comments

@ixti
Copy link
Owner

ixti commented May 16, 2016 •
edited
Loading

Since Sidekiq 4.0 BasicFetch changed the way it creates queues list:

  • no more @unique_queues variable
  • @queues include TIMEOUT argument as last element in case of strictly ordered queues.

Kudos to @palanglung for discovering that and preparing initial fix for that.
@ixti
Copy link
Owner Author

ixti commented May 16, 2016

Fixed with #12 and 15d083c

@ixti ixti closed this as completed May 16, 2016
ixti pushed a commit that referenced this issue Apr 6, 2023
@adipasquale @ixti
fix timeout deprecation warning for redis 4.8.0 (#13)
d12c98b 
* fix timeout deprecation warning for redis 4.8.0 

fixes deprecation notice: Passing the timeout as a positional argument is deprecated, it should now be passed as a keyword argument.

this change was introduced in redis 4.8.0 https://github.com/redis/redis-rb/blob/master/CHANGELOG.md#480

```
Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
  redis.brpop("queue:mailers", "queue:api_call", "queue:scheduled", "queue:searchkick", "queue:active_storage_analysis", "queue:active_storage_purge", "queue:default", timeout: 2)(called from: /home/xxx/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-throttled-0.16.2/lib/sidekiq/throttled/fetch.rb:94:in `block in brpop')
```

this should fix #124

* fixing ci and lint

* fixing fetch spec
ixti pushed a commit that referenced this issue Apr 6, 2023
@adipasquale
fix timeout deprecation warning for redis 4.8.0 (#13)
2100c64 
* fix timeout deprecation warning for redis 4.8.0 

fixes deprecation notice: Passing the timeout as a positional argument is deprecated, it should now be passed as a keyword argument.

this change was introduced in redis 4.8.0 https://github.com/redis/redis-rb/blob/master/CHANGELOG.md#480

```
Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
  redis.brpop("queue:mailers", "queue:api_call", "queue:scheduled", "queue:searchkick", "queue:active_storage_analysis", "queue:active_storage_purge", "queue:default", timeout: 2)(called from: /home/xxx/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-throttled-0.16.2/lib/sidekiq/throttled/fetch.rb:94:in `block in brpop')
```

this should fix #124

* fixing ci and lint

* fixing fetch spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ixti