Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange issue with sidekiq 4.0 #9

Closed
ixti opened this issue Apr 29, 2016 · 1 comment
Closed

Strange issue with sidekiq 4.0 #9

ixti opened this issue Apr 29, 2016 · 1 comment
Assignees
Labels

Comments

@ixti
Copy link
Owner

ixti commented Apr 29, 2016

It seems like throttle keys are not properly evicted.

After upgrade we saw strange behavior when amount of throttled jobs was higher than amount of busy workers and was not going down.

@ixti ixti self-assigned this Apr 29, 2016
@ixti ixti added the bug label Apr 29, 2016
@ixti ixti added this to the 0.3.0 milestone Apr 29, 2016
@ixti
Copy link
Owner Author

ixti commented May 2, 2016

After investigation, it seems like this is absolutely legit, due to nature of how stats are collected.
Our stats are pretty simple, and have complexity of O(1) (if either :concurrency or :throttle only limit given) or O(2) (if both :concurrency and :throttle limits are given) per throttle key (worker class in most cases):

Stats of sidekiq are calculated using way more complex logic.

@ixti ixti closed this as completed May 2, 2016
ixti pushed a commit that referenced this issue Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant