Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: test case seem to have three adults in a Bedarfsgemeinschaft #731

Closed
ChristianZimpelmann opened this issue Apr 25, 2024 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@ChristianZimpelmann
Copy link
Member

the test case src\_gettsim_tests\test_data\benefit_checks\2011\hh_id_5.yaml consists of three adults, but the input variables seem to imply that they are all part of the same Bedarfsgemeinschaft. This should not be possible.

Possibe solutions

  • Delete this test case
  • Adjust it to a proper test case in which Wohngeld is potentially paid for all three subjects on the hh-level, but ALG 2 is potentially paid in two separate Bedarfsgemeinschaften. Not sure though whether we already handle the Günstigerprüfung correctly (I don't even know how what is correct in such a case).
@ChristianZimpelmann ChristianZimpelmann added the enhancement New feature or request label Apr 25, 2024
@hmgaudecker
Copy link
Collaborator

Just since I was confused for a bit. We pass arbeitsl_geld_2_regelbedarf_m_bg, which is the same for all adults. Cannot be the case if the Bedarfsgemeinschaft was created endogenously, but we don't check that.

I am sort of indifferent between the two solutions. In any case, we should at some point have test cases for households with multiple bg's. Not sure whether this one is a particularly good start, though. @MImmesberger, your call!

@MImmesberger
Copy link
Collaborator

Properly testing Wohngeld vs Bürgergeld makes sense once we fixed #710.

I will remove one adult from the test date, I think the test doesn’t rely on having three adults (might have missed something when looking at it quickly. Will take a proper look tomorrow).

@MImmesberger
Copy link
Collaborator

Closed via #751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants