Improved performance of annotateUtil
.
#2465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not good at English, so I apologize if I am rude.
Summary of Changes
Changed
annotateUtil
function to not useLocal function
.Rationale for Performance Improvement
Decompile the current
getBracketLevel
function toJava
as followsFrom this result, we can read that the
getBracketLevel
anditerateParents
functions are instantiated at each call toannotateUtil
, and that theiterateChildren
function is instantiated at each loop ofiterateParents
.Modifying to not use
Local function
would improve performance by eliminating these instantiation costs.