Rainbow variables in C# shouldn't color types

[mtpilarek]

Your programming language

C#

Expected Behavior

Types, interfaces and enums shouldn't be colored, but have one static color.
For enums and interfaces it should be this one:

For classes it should be this one:

Coloring types is really confusing and makes file less readible. I suggest at least to make it configurable. In my opinion it's a bug, but maybe some would concider it as a feature.

Current Behavior

Types, interfaces and enums are treated like a variable.

Code snippet for reproduce (for bugs)

Open any C# file.

Your Environment

JetBrains Rider 2022.3.1

• Plugin version:
  Rainbow Brackets 2023.1.0

[open-collective-bot]

Hey @mtpilarek 👋,

Thank you for opening an issue/feature request. We will get back to you as soon as we can.

Please consider support us by buying a license here or donating from OpenCollective https://opencollective.com/intellij-rainbow-brackets.

And we have a special plan for paid users, if you are a paid user, your issue or feature request will have a higher priority.

If you are creating a issue, please make sure you already read the latest change log here.

[izhangzhihao]

True, since the dummy C sharp light parser from the Rider IDE could not tell me the real stuff behind the PSI tree, what this plugin could find is only something created by IDENTIFIERs, but I will have to try to find some pattern, and handle some cases.

[jansviland]

Just want to add to this, I have the same issue. Can not use this feature in C#.

This should be highlighted:

This is the result. Everything is highlighted.

[izhangzhihao]

Hi @jansviland please provide your code sample, so I could reproduce this issue and fix.

[jansviland]

Hi @jansviland please provide your code sample, so I could reproduce this issue and fix.

Of course, the example above can be found here:
https://github.com/jansviland/AdventOfCode/blob/main/2022/AdventOfCode.2022.Day7.Tests/Tests.cs

[mtpilarek]

Better, but not there yet.

Still coloring types here.

Here some variables not colored (_settings)
Some strange coloring for initializer of first prop (TotalCount)
Coloring constructor (ArchitectsTeamsDto)
Still coloring types in method definition.

[mtpilarek]

Better, but:

Private variables not colored

totalCount changed coloring in conditional statement

Also sometimes variables next to each other have same colors:

settingsInterfaceType and factoryMethod

searchableType and searchableTypeGeneric

I think plugin should try to differ colors for variables close to each other/in the same scope. Don't really know if it's possible, but it would be nice.

[izhangzhihao]

Ah, are you using the color generator for rainbow variables or the default color config?

[mtpilarek]

Do u mean this feature? I can't select this, because after saving and entering settings afterwards it is not selected again. After restart it is also deselected.

And as you can see I have purchased Rainbow Brackets.

[izhangzhihao]

Does this help you?

[mtpilarek]

It didn't help, maybe it's because I have installed build from your previous comments?
It's something with this specifing options, because other paid features work. For example color generator lumosity works.

[izhangzhihao]

Thanks! this is another bug, I will fix it later!

[mtpilarek]

Option is now working, but the issue with same coloring persists.

[izhangzhihao]

[mtpilarek]

Much better now.
The only persisting issue I can find is this one:

totalCount changed coloring in conditional statement

[mtpilarek]

Did you manage to fix conditional statement?

The easiest way to reproduce it is make simple statement with ? and :

I've just also spotted that similar bug appears in constructor arguments. If we use same variable in constructor arguments it changes coloring.