Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate color schemes for Light and Dark modes #2670

Closed
2 tasks done
hirozed opened this issue Sep 8, 2023 · 3 comments
Closed
2 tasks done

Separate color schemes for Light and Dark modes #2670

hirozed opened this issue Sep 8, 2023 · 3 comments

Comments

@hirozed
Copy link

hirozed commented Sep 8, 2023

Please support us before creating a feature request, thanks for your support 馃榿

Please check

  • please do consider buy this plugin here or donating us on Open Collective Or by AliPay/WeChatPay.
  • This issue/feature request is not reported before.

Your programming languages

PHP

Expected Behavior

  • The colors will adjust colors when Intellij switches from light to dark when "Sync with OS" is selected.

Current Behavior

  • The color scheme for detected for a light theme will mostly not work on a dark color scheme.
  • The only way to correct it is to restart Intellij

Code examples

  • My apologies, I don't have any code that I'm free to share.
@izhangzhihao
Copy link
Owner

izhangzhihao commented Sep 9, 2023

Hi, I tested two cases:

  1. Without enabling the Color Generator
image and with the "Sync with OS" enabled, after switching the light/dark, the brace colors changed automatically without restarting the IDE.
  1. With the Color Generator and the "Sync with OS" enabled, the brace colors do not change automatically after switching the light/dark.

@izhangzhihao
Copy link
Owner

izhangzhihao commented Sep 9, 2023

I can make brackets automatically updated after switching light/dark, but for Rainbow Variables, there is still an open issue from JB: Incorrect Semantic Highlighting colors when switching to dark mode

And do please try this build snapshot

@hirozed
Copy link
Author

hirozed commented Sep 11, 2023

Hi @izhangzhihao,

Thank you for looking into this. I bounced around the settings with color generator activated and not, and it looked like the colors were changing with the theme, but it felt inconsistent. I'll stay with a single color theme and see if the next release solves things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants