Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The return type should be nullable in SessionsEmspRepository.getSession #28

Closed
andacata opened this issue Dec 1, 2023 · 2 comments · Fixed by #35
Closed

The return type should be nullable in SessionsEmspRepository.getSession #28

andacata opened this issue Dec 1, 2023 · 2 comments · Fixed by #35
Labels
bug Something isn't working module: sessions

Comments

@andacata
Copy link
Contributor

andacata commented Dec 1, 2023

Hi team,
Congratulations for the good job you're doing.

As I'm testing the library, I found some issues.

ocpi-toolkit/ocpi-toolkit-2.2.1/src/main/kotlin/com/izivia/ocpi/toolkit/modules/sessions/repositories/SessionsEmspRepository.kt

Line 30 in 76cfc19

suspend fun getSession(countryCode: CiString, partyId: CiString, sessionId: CiString): Session

The return type should be nullable, because the session may not be found.
@lilgallon
Copy link
Member

Hi, thanks for your report, you are right, it has to be fixed

@lilgallon lilgallon added bug Something isn't working module: sessions labels Dec 1, 2023
@andacata andacata mentioned this issue Dec 4, 2023
Merged
@lilgallon
Copy link
Member

done in 0.0.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module: sessions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ocpi-2.2.1) nullable return in SessionsEmspRepository.getSession andacata/ocpi-toolkit
2 participants
@andacata @lilgallon