New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET /versions with an invalid TOKEN_A returns HTTP 400 instead of an HTTP 401 #46

Closed

andacata opened this issue Dec 18, 2023 · 1 comment · Fixed by #55

Labels

bug module: credentials

Contributor

andacata commented Dec 18, 2023

As the documentation states:

If the header is missing or the credentials token doesn’t match any known party then the server SHALL respond with an HTTP 401 - Unauthorized status code.

But in the current implementation, the GET /versions with an incorrect CREDENTIALS_TOKEN_A is returning an HTTP 400.

Member

lilgallon commented Dec 20, 2023

Thanks for your report. A good fix should include a unit test that checks that

lilgallon added bug module: credentials labels

andacata mentioned this issue

fix(ocpi-2.2.1) versions endpoint should return http 401, not 400 #55

Merged

lilgallon closed this as completed in #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment