[IZPACK-1069] Allow dynamic views on panels

[mtjandra]

This is to address http://jira.codehaus.org/browse/IZPACK-1069
Refer to the link above for more information.

Allows a checkbox or radio button to show additional fields on the same userInputPanel, if conditions specified correctly. Ensures that fields are not validating during this process, validation only needs to occur when pressing the next button.

Allow specifying the topBuffer as number of pixels with the "rigid" attribute. This comes naturally and dynamically showing and hiding fields make the spacing between the top field and title change.

Let me know if anything needs clarification, and am fully open to feedback!

EDIT: Forgot to add functionality in console mode. Currently work in progress.
Checks to see if a console field should be displayed have been added, but I realize it kind of duplicates the code from the updateView() method of the GUI type fields. I plan to eventually come back to this in a seperate PR and find a way to abstract this out.

[buildhive]

IzPack project » izpack #390 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[buildhive]

IzPack project » izpack #391 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[unb]

Some comments:

• For the console fields, the following changes to the display() method:

    if (!getField().isConditionTrue())
    {
          return true;
    }

can be simplified by moving it to UserInputConsolePanel:

if (getField().isConditionTrue() && !field.display())
{
    // field is invalid
    rerun = true;
    break;
}

• The duplicated code in the various GUIField implementations:

if (getField().isConditionTrue())
{
    if (!isDisplayed())
    {
        result = true;
    }
    setDisplayed(true);
}
else
{
    if (isDisplayed())
    {
        result = true;
    }
    setDisplayed(false);
}

should be moved to UserInputPanel.updateUIElements()

• The rigid attribute needs to be added to the izpack-userinput-5.0.xsd schema in izpack-dist\src\main\resources\schema\5.0 and the topBuffer documentation changed.

[buildhive]

IzPack project » izpack #392 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[mtjandra]

• Changes to console display() method have been simplified as suggested
• Duplicated code in various GUIField implementations have been moved as suggested
• izpack-userinput-5.0.xsd schema has been updated as suggested

Thank you for the feedback!
The build error "ERROR: Error cloning remote repo 'origin'" does not seem to be related to my changes.
Not sure what the cause of this is.

[unb]

Do ConsoleInputField and ConsoleChoiceFIeld still need the following in display()?

       if (!getField().isConditionTrue())
        {
            return true;
        }

[mtjandra]

I don't believe they do, sorry I must have missed them.

[buildhive]

IzPack project » izpack #393 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[rkrell]

The build failure is in fact a problem on the build system itself. I've seen this more times the last couple of weeks. Sometimes Githib went down. Will try a rebuild.