Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired checker #312

Merged
merged 11 commits into from Feb 16, 2015
Merged

Expired checker #312

merged 11 commits into from Feb 16, 2015

Conversation

optotronic
Copy link

This checker lets installers automatically expire on a date specified by variable "InstallerExpiresDate" in the installer XML file. The date must be in the format "yyyy-MM-dd". If "InstallerExpiresDate" is not defined, the installer does not expire.

@buildhive
Copy link

IzPack project » izpack #692 SUCCESS
This pull request looks good
(what's this?)

@rkrell
Copy link
Member

rkrell commented Feb 5, 2015

Thank you for this contribution.
Would you please make a JIRA issue from that for us to get a clean changelog, please.
Please add also a usage example to that issue and primarily document this in Confluence.
If you do so in time, this would be probably the last new feature to 5.0 RC5 and maybe even 5.0.0 before finally releasing it.

@rkrell rkrell added this to the 5.0 RC5 milestone Feb 5, 2015
@rkrell rkrell self-assigned this Feb 5, 2015
@optotronic
Copy link
Author

Thanks, René. Who do I talk to to get JIRA and Confluence accounts?

@rkrell
Copy link
Member

rkrell commented Feb 5, 2015

You should be able to register to Codehaus Xircles. With the account there
you can go further. Some time ago I wrote this down here: http://docs.codehaus.org/display/IZPACK/Contributing+Code+Changes

@rkrell
Copy link
Member

rkrell commented Feb 5, 2015

If you grab a Xircles account, login and look here:

Thank you

@optotronic
Copy link
Author

Thanks, René. I'm still waiting for the Xircles verification email. It's been > 45 minutes.

@optotronic
Copy link
Author

I tried creating three different accounts in Xircles with three different emails, usernames, and passwords, but have not received any verification emails yet. I sent an email to support at codehaus.org but received no response. It looks like I can't raise an issue about not being able to create an account without an account. When I get an account I'll create the JIRA request and update the docs.

BTW, your Contributing+Code+Changes doc looks very useful. Wish I'd seen it before I started!

@rkrell
Copy link
Member

rkrell commented Feb 6, 2015

Oh really? Did you try to raise an issue to http://jira.codehaus.org/secure/BrowseProject.jspa?id=10104 ? Didn't it end in a spam folder? ;-)

The Contributing+Code+Changes has been completed one by one from the view of a developer knowing Java but not being so familar with Git and Github. There are just a very few basics of handling code changes and a pull request, just to have a checklist of the essential steps.

@optotronic
Copy link
Author

The codehaus.org mail server is on the spamrats.com blacklist, and the emails were bounced before they got to my mailbox. (The messages did not appear in any spam filters or folders accessible to me.) I successfully used an email account on a different domain that did not use this blacklist to create my accounts.

I created a JIRA issue IZPACK-1219. I also added to the Dynamic Installer Requirements page you referenced.

@buildhive
Copy link

IzPack project » izpack #702 SUCCESS
This pull request looks good
(what's this?)

rkrell added a commit that referenced this pull request Feb 16, 2015
@rkrell rkrell merged commit 9999dab into izpack:master Feb 16, 2015
@rkrell
Copy link
Member

rkrell commented Feb 16, 2015

Thanks for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants