Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IZPACK-1295 #396

Merged
merged 2 commits into from Oct 26, 2015
Merged

IZPACK-1295 #396

merged 2 commits into from Oct 26, 2015

Conversation

stenix71
Copy link
Collaborator

Pull request that fixes IZPACK-1295
https://izpack.atlassian.net/browse/IZPACK-1295

Fixed problem that packs were installed in wrong order while using console mode.

This is a show-stopper for us so I would appreciate swift handling.
Cheers
Jonas

@buildhive
Copy link

IzPack project » izpack #890 SUCCESS
This pull request looks good
(what's this?)

@stenix71 stenix71 closed this Oct 26, 2015
@buildhive
Copy link

IzPack project » izpack #891 SUCCESS
This pull request looks good
(what's this?)

@stenix71
Copy link
Collaborator Author

Should I close a pull request or leave it open? Sorry, I am a bit new to Github.

@stenix71 stenix71 reopened this Oct 26, 2015
@buildhive
Copy link

IzPack project » izpack #892 SUCCESS
This pull request looks good
(what's this?)

@stenix71
Copy link
Collaborator Author

Ok, I found it. I should leave it open. It was not my intention to add both these files to the same pull-request. My intention was to create two pull requests. Hope this does not complicate things at your end.

@rkrell
Copy link
Member

rkrell commented Oct 26, 2015

This comes in time. Release 5.0.6 will be marked by console installer fixes and improvements.
BTW, the updated swedish language pack that has crept in to this branch should be also merged? No problem for me, if it is ok for you aas a native speaker :-)

rkrell added a commit that referenced this pull request Oct 26, 2015
@rkrell rkrell merged commit ffb56f5 into izpack:master Oct 26, 2015
@rkrell
Copy link
Member

rkrell commented Oct 26, 2015

Thanks for contributing.

@rkrell rkrell added this to the 5.0.6 milestone Oct 26, 2015
@rkrell rkrell self-assigned this Oct 26, 2015
@rkrell rkrell added the bug label Oct 26, 2015
@stenix71
Copy link
Collaborator Author

It is fine by me to merge the Swedish language pack as well. I just added translations to some strings that had been added to the English language pack but did not exist in the Swedish pack.

@rkrell
Copy link
Member

rkrell commented Oct 27, 2015

It is very appreciated to help with translations, if you are a native speaker. Great!

@rkrell
Copy link
Member

rkrell commented Oct 27, 2015

Please test the latest 5.0.6-SNAPSHOT from Sonatype OSS Snapshots or compiled from master, whether it fits for you. Planned to be released soon.

@stenix71
Copy link
Collaborator Author

I have tested the console installer compiled from master and as far as I can see it works fine now. I have found some minor issues about "executable" that was not related to this release so I will file a new bug report about that if it has not been reported already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants