Fixed problem with XDG shortcuts https://groups.google.com/forum/#!to… #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThibLind could you update you're feature branch with the latest changes? |
|
Hello, Thank you for your response. It's done. Sincerely, Thibault LINDECKER |
akuhtz
approved these changes
Nov 12, 2020
|
@ThibLind can you rebase your change in order to be merged? |
ThibLind
force-pushed
the
shortcut_on_kde
branch
from
e0d8939
to
b9c0052
Compare
|
All is good for you now ? |
|
👍 Thank you. |
|
@akuhtz have you already opened an issue? |
|
@ThibLind Would you update the patch with the fix for Windows? That would be less work for us 😉 |
|
@akuhtz is there any work left to do before merge? |
|
@reinhapa Yes, there is a fix for Windows OS in the referenced google groups thread. I have not seen this earlier unfortunately. But maybe merge this PR now and have another for the Windows issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear IzPack developers,
Some time ago, I reported two problems (one on Linux and one on Windows) with shortcuts, please see https://groups.google.com/forum/#!topic/izpack-user/UrLck2vG-6U . This is the fix for the problem under Linux. If you accept this patch, then I will submit the other patch for the Windows problem.
Sincerely,
Thibault LINDECKER
PS: Thank you for this great free software!