-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Atom 0.121 #19
Comments
Thanks for the bump, just published version 0.9.0 with the fix for Atom 0.121.0 |
Sorry, I just updated pdf-view and get this message after start up from the incompatible packages view:
|
@aengelke Sorry, I'm not seeing that problem. Can you share more details please? Which version of Atom are you using? Have you tried uninstalling pdf-view completely and then re-installing? |
I'm using Atom 0.121. One problem with the pathwatcher package were some warnings (see issue atom/node-pathwatcher#38). With disabling The installation through apm doesn't work at all, since pathwatcher won't compile without a tweak (see above). Edit: I have VS 2010 installed. Even replacing pathwatcher and runas with the versions shipped with atom doesn't help. |
Interesting, thanks for the details. Just to make sure -- does the same problem happen on 0.123.0? Also, from what you're saying (and I might be misunderstanding) -- this is an issue with node-pathwatcher? Do you have a suggestion how this package might work around this build problem in node-pathwatcher? |
@izuzak This still happens with 0.123.0, nan now gives a warning (c4244). Actually, it is not an issue with this package, as other packages have the same issues. A temporary work around: don't use node-pathwatcher. (How to detect file changes then?) Edit: I tweaked my pdf-view to work without the pathwatcher module, and added a |
Pathwatcher is reported to be incompatible ..? It fails with
Error: no error
.The text was updated successfully, but these errors were encountered: