Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Atom 0.121 #19

Closed
aengelke opened this issue Aug 13, 2014 · 7 comments · Fixed by #20
Closed

Update for Atom 0.121 #19

aengelke opened this issue Aug 13, 2014 · 7 comments · Fixed by #20

Comments

@aengelke
Copy link

Pathwatcher is reported to be incompatible ..? It fails with Error: no error.

@izuzak
Copy link
Owner

izuzak commented Aug 13, 2014

Thanks for the bump, just published version 0.9.0 with the fix for Atom 0.121.0

@aengelke
Copy link
Author

Sorry, I just updated pdf-view and get this message after start up from the incompatible packages view:

runas@1.0.1 - Error message: no errorc:\Users\aengelke\.atom\packages\pdf-view\node_modules\pathwatcher\node_modules\runas\build\Release\runas.node

@izuzak
Copy link
Owner

izuzak commented Aug 18, 2014

@aengelke Sorry, I'm not seeing that problem.

Can you share more details please? Which version of Atom are you using? Have you tried uninstalling pdf-view completely and then re-installing?

@aengelke
Copy link
Author

I'm using Atom 0.121. One problem with the pathwatcher package were some warnings (see issue atom/node-pathwatcher#38). With disabling WarnAsError, it all compiles fine. The runas module compiles without any errors or warnings. And yes, it is a re-install after removing the old version of pdf-view.

The installation through apm doesn't work at all, since pathwatcher won't compile without a tweak (see above).

Edit: I have VS 2010 installed. Even replacing pathwatcher and runas with the versions shipped with atom doesn't help.

@izuzak
Copy link
Owner

izuzak commented Aug 18, 2014

Interesting, thanks for the details. Just to make sure -- does the same problem happen on 0.123.0?

Also, from what you're saying (and I might be misunderstanding) -- this is an issue with node-pathwatcher? Do you have a suggestion how this package might work around this build problem in node-pathwatcher?

@kenowessels
Copy link

untitled 2014-08-18 15 36 56

I got this error message after updating to Atom 0.123.0

trying to update PDF-View is failing:
untitled 2014-08-18 15 40 53

@aengelke
Copy link
Author

@izuzak This still happens with 0.123.0, nan now gives a warning (c4244). Actually, it is not an issue with this package, as other packages have the same issues. A temporary work around: don't use node-pathwatcher. (How to detect file changes then?)

Edit: I tweaked my pdf-view to work without the pathwatcher module, and added a pdf-view:reload command to trigger the reload manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants