Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System crash when rescanning the titles #32

Closed
muxi1 opened this issue May 22, 2020 · 22 comments
Closed

System crash when rescanning the titles #32

muxi1 opened this issue May 22, 2020 · 22 comments

Comments

@muxi1
Copy link

muxi1 commented May 22, 2020

Hello @J-D-K
The Title Rescan option in version 05.20.2020 causes a system crash.

err

@J-D-K
Copy link
Owner

J-D-K commented May 22, 2020

Is it consistent, or are you enabling options first? There are two that would make it load more than before.

@muxi1
Copy link
Author

muxi1 commented May 22, 2020

I don't understand exactly what you mean by your question, but as soon as I start JKSV and select Title Rescan in the options (ZR), the system crashes.

@J-D-K
Copy link
Owner

J-D-K commented May 22, 2020

That actually answers it for me. I meant that in the options menu, there's two options. Force Mount and Account Sys Saves. Both of which will change what is ignored while loading.

Is there a reason you're rescanning? It's only really there for those options and when you terminate something to see what else you can get into. I'll get back to ya with a build that'll tell me something when I can.

@muxi1
Copy link
Author

muxi1 commented May 22, 2020

No, there was no need for me to rescan. I just wanted to test the function and that's what caused the system to crash.

The option "Force Mount"is set to ON and "Account sys Saves" is set to OFF. This is set by default but has nothing to do with the crash, right?

@J-D-K
Copy link
Owner

J-D-K commented May 22, 2020

No, it shouldn't cause any crashes. That's the way JKSV has always ran. It ignored things that couldn't be opened and couldn't open the account system stuff cause of my own mistake. I've tweaked something in this build and added code to sort of log the rescan function. It should give me a rough idea of where it's getting caught. Upload the JKSV/log.txt to pastebin or something. Logging JKSV's title loading can get massive, so I'm only catching title ids and what user is returned.
JKSV.zip

@muxi1
Copy link
Author

muxi1 commented May 23, 2020

Hi,
here is the log file. I hope it's helpful.

log.txt

@J-D-K
Copy link
Owner

J-D-K commented May 23, 2020

Thanks. It's what I suspected. It's finding a new user in rescan which is very odd.

@muxi1
Copy link
Author

muxi1 commented May 23, 2020

I have only set up a single user.

@J-D-K
Copy link
Owner

J-D-K commented May 23, 2020

It's finding something new. I don't know what yet. -1 is returned when a user hasn't been loaded before. It's probably system stuff.

@muxi1
Copy link
Author

muxi1 commented May 23, 2020

I have previously restored a save from ACNH from another console and another user, but that certainly wasn't the reason, was it?

Edit:
I deleted the ACNH save to see if the crash might be related, but there is still a system crash with the Title Rescan option. So it won't have anything to do with that.

@J-D-K
Copy link
Owner

J-D-K commented May 23, 2020

I don't believe so. This build should get around it, but there is something the first one is skipping that the stripped down version sees. I wonder what it is?
JKSV.zip

@muxi1
Copy link
Author

muxi1 commented May 23, 2020

With this build the system no longer crashes. Did you just disable this feature or fix the problem?

@J-D-K
Copy link
Owner

J-D-K commented May 23, 2020

I didn't disable the rescan. I added code to bypass the problem until I have time to properly fix it.

@muxi1
Copy link
Author

muxi1 commented May 23, 2020

Ah ok, that makes sense.

@J-D-K
Copy link
Owner

J-D-K commented May 24, 2020

Let me know how this goes. I cleaned up the data file a lot. The initial load and rescan use the same function. I'm more curious about if this one will catch the problem user thing.
JKSV - 05.24.2020.zip

@muxi1
Copy link
Author

muxi1 commented May 25, 2020

I can't judge if the title rescan function works, but even with this new version there is at least no system crash when it is executed. What's the point of this option shown here? This is probably new, since it was not available in the last version.

jksv

@J-D-K
Copy link
Owner

J-D-K commented May 25, 2020

That would be the mystery user account that was making it crash before. Is there anything in it? Or, do you get the nothing found pop up?

Judging by the ID string, it's system related, actually.

@muxi1
Copy link
Author

muxi1 commented May 25, 2020

DLCs from Doom 1993 are stored there.

jksv

@J-D-K
Copy link
Owner

J-D-K commented May 25, 2020

Neat. Does the folder menu tell you what save data type it is? I actually added code for all of them, but I only have code to make fake users for device saves and the other two.

@J-D-K
Copy link
Owner

J-D-K commented May 25, 2020

Also, congrats. We found something new JKSV can do. Yay

@muxi1
Copy link
Author

muxi1 commented May 25, 2020

Here is the content of one of the 6 icons. The data are all identical except for the SID. The DLCs of Doom 1993 are probably stored differently, as it is usually done.

These DLCs (Add ons) can be dumped, but they can't be restored, which would be surprising, because for a restore the corresponding data must already be available, as it is the case with the saves, if I see it correctly.

jksv

@J-D-K
Copy link
Owner

J-D-K commented May 25, 2020

I've added code to handle the rest of the save data types and add a fake user if they exist. Well, I think I did. I don't have any to check. If this picks it up and registers it as a user named "Cache", I'm going to consider this fixed. If it isn't crashing on the original title load, the rescan won't either since they're using the same code now.
JKSV - 05.25.2020.zip

@J-D-K J-D-K closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants