Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Keep config #4

Closed
likkai opened this issue Jul 31, 2022 · 6 comments
Closed

Question: Keep config #4

likkai opened this issue Jul 31, 2022 · 6 comments

Comments

@likkai
Copy link

likkai commented Jul 31, 2022

When I updated the module through magisk, my configuration was lost. Is it possible to keep those configurations after updating?

@j-hc
Copy link
Owner

j-hc commented Jul 31, 2022

  1. did you build locally or on actions?
  2. what config are you talking about?

@likkai
Copy link
Author

likkai commented Jul 31, 2022

  1. I built the root version (17.28.34) using actions and upgraded to version 17.29.34 through magisk
  2. The config I was talking about was excluding the patches (-e packagename) in the file build.conf

@j-hc
Copy link
Owner

j-hc commented Jul 31, 2022

well that shouldnt happen. module you built on your repo will always use your build.conf file. you can have a look at workflow logs.

@likkai
Copy link
Author

likkai commented Jul 31, 2022

I think I wasn't clear just now so I'll explain it again 😅
The module I built on GitHub used my build.conf file (works normally) but afterwards when I update the module from the magisk update button (I didn't build it again on GitHub), the patches I excluded was included.
For example, I built the module with -e custom-branding, is there a way to update the module through magisk (not building it on GitHub) with the same configurations I saved in the build.conf file? (The -e custom-branding patch)

@j-hc
Copy link
Owner

j-hc commented Jul 31, 2022

The thing is if you didnt build again, you cant possibly receive an update from inside magisk. I would make sure you are not using the module from my repo as that way you would receive updates from my repo. you can go to /data/adb/modules/ytrv-magisk/module.prop file and see the updatejson if it points to your repo.

@likkai
Copy link
Author

likkai commented Jul 31, 2022

I see, thanks for your help

@likkai likkai closed this as completed Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants